Repository navigation
ci: Run Moby extension integration tests - #8
Conversation
ca3a92b to
91eff02
Compare
Signed-off-by: Paweł Gronowski <git@grono.dev>
| go mod edit -replace=github.com/moby/extensions="${GITHUB_WORKSPACE}/extensions" | ||
| go mod tidy | ||
| go mod vendor |
There was a problem hiding this comment.
Wondering if we should look if go.work is suitable for this;
go work init .
go work edit -replace=github.com/moby/extensions="${GITHUB_WORKSPACE}/extensions"
go work vendorThere was a problem hiding this comment.
Not sure if there's any difference in this case? It's only a temporary checkout to run the tests from
There was a problem hiding this comment.
Yeah; I was trying to see if we could make it more align with the intended use of Go.
I was hoping go.work could "augment" the replaced module;
- use
github.com/moby/mobyandvendor/ - but use
${GITHUB_WORKSPACE}/extensionsfor the extensions module
But unfortunately that doesn't work when using vendor/ - in that case, it only looks at the vendor/ directory so it either must re-vendor, or we need to disable vendor mode, and download all modules.
☝️ I should mention that go mod vendor would already download all modules, so ... perhaps not the worst, but it likely requires changes in the moby integration tests, which assume vendor 🤔
Would look something like;
cd "$GITHUB_WORKSPACE"
go work init ./moby ./extensions
cd moby
GOFLAGS=-mod=readonly make test-integrationThere was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow correctly builds Moby against the proposed extension code and reports integration failures.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Moby extension integration tests to CI.
Changes:
- Checks out Moby and replaces its extensions dependency with the PR source.
- Builds Moby’s development image and runs extension integration tests.
- Includes integration results in the required success job.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds and gates CI on Moby integration testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Oh! CI is failing though; |
Signed-off-by: Paweł Gronowski <git@grono.dev>
No description provided.