Brain GUI modernization (Phase 2)#14062
Open
payamsash wants to merge 9 commits into
Open
Conversation
payamsash
requested review from
agramfort,
drammock,
larsoner and
wmvanvliet
as code owners
July 17, 2026 11:56
larsoner
reviewed
Jul 18, 2026
larsoner
left a comment
larsoner
left a comment
Member
There was a problem hiding this comment.
Just a tiny drive-by comment from me, I'll let @wmvanvliet look and merge if he's happy (unless busy in which case I can look deeper!)
| hemi="lh", | ||
| show_traces=False, | ||
| add_data_kwargs=dict(colorbar_kwargs=dict(title=long_title)), | ||
| ) |
Member
There was a problem hiding this comment.
There is a fixed overhead to creating these brain windows (~0.5s locally and longer on CIs), so as much as possible try to reuse some existing brain for tests if you can
Contributor
|
Now that the previous PR is merged, this PR needs the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Phase 2 of #14042 and following #14054.
What does this implement/fix?
Additional information
Claude created 2 .svg icons (light and dark) for information button.
most of the diff comes from #14054.