ENH: Add in_argmax mode to better match older MaxFilter#14059
Open
larsoner wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally chased down something that has bugged me for a while: why our regularization never really matched
maxfilter's. Turns out that we are using the "new and improved" version based on a percentage threshold but the test files I generated many years ago used maxfilter 2.2, which used a (less good) information maximization mode. This PRregularize="in_argmax"This was done with the help of Claude Opus 4.8, which ran a lot of tests with
maxfilter, helped test my hypotheses about why our results might differ, and write initial code for updated tests etc. (which I then modified to be more MNE-style).