Skip to content

chore: remove --max-warnings=0 from eslint commands - #87

Merged
dinwwwh merged 1 commit into
mainfrom
chore/remove-eslint-max-warnings
Sep 6, 2026
Merged

chore: remove --max-warnings=0 from eslint commands#87
dinwwwh merged 1 commit into
mainfrom
chore/remove-eslint-max-warnings

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Sep 6, 2026

Copy link
Copy Markdown
Member

Drops --max-warnings=0 from every eslint invocation so lint warnings no longer fail the check; only errors do.

Applies to the lint, lint:fix, and sponsors:sync scripts and the lint-staged pre-commit command. Same change is being applied to middleapi/openapi-spec and middleapi/orpc.

@pkg-pr-new

pkg-pr-new Bot commented Sep 6, 2026

Copy link
Copy Markdown
@standardserver/aws-lambda

npm i https://pkg.pr.new/@standardserver/aws-lambda@87

@standardserver/core

npm i https://pkg.pr.new/@standardserver/core@87

@standardserver/fastify

npm i https://pkg.pr.new/@standardserver/fastify@87

@standardserver/fetch

npm i https://pkg.pr.new/@standardserver/fetch@87

@standardserver/node

npm i https://pkg.pr.new/@standardserver/node@87

@standardserver/peer

npm i https://pkg.pr.new/@standardserver/peer@87

@standardserver/shared

npm i https://pkg.pr.new/@standardserver/shared@87

commit: 4e167e6

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Relax lint gating to errors only — drops --max-warnings=0 from all four eslint invocation sites in package.json (lint, lint:fix, sponsors:sync, and the lint-staged pre-commit command), so warnings no longer fail the check.

The removal is complete and consistent: a repo-wide search finds no remaining --max-warnings=0 and no other eslint invocations (sub-package manifests have no lint scripts; dependabot.yml only groups the package names). CI's lint_and_typecheck job runs pnpm run lint, so this relaxes the CI gate from "errors or warnings fail" to "errors fail" — exactly the documented intent of the chore, matching the parallel org-wide change. Nothing blocking.

Pullfrog  | View workflow run | Using DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏

@codspeed-hq

codspeed-hq Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 108 skipped benchmarks1


Comparing chore/remove-eslint-max-warnings (4e167e6) with main (388fe25)2

Open in CodSpeed

Footnotes

  1. 108 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (c200b8b) during the generation of this report, so 388fe25 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@dinwwwh
dinwwwh merged commit 923ba83 into main Sep 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant