fix: initialize child bindings before connection#329
Open
mohamedmansour wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed the WebUI browser runtime so new client-created child components receive parent
:propvalues before theirconnectedCallback()runs.Before, when a parent was created in the browser, WebUI appended child elements to the DOM first. That caused the child's
connectedCallback()to run before the parent pushed bound properties like:value="{{val}}". Then the parent's first binding pass could overwrite whatever fallback the child set.Now the runtime:
connectedCallback()with initial bindings already available.I also fixed tricky repeat/conditional cases so this still works when children are created later by
<if>or<for>, including nested repeats and keyed reorder cases.Closes #324
Validation
pnpm --dir packages/webui-framework testpnpm --dir docs buildcargo xtask check