Repository navigation
Fix npm ci lockfile sync failure in signing pipeline; move CI to Node 24 - #5053
Open
Vidal Ortega (vidorteg) wants to merge 1 commit into
Open
Vidal Ortega (vidorteg) wants to merge 1 commit into
Vidal Ortega (vidorteg) wants to merge 1 commit into
Conversation
The ESRP signing pipeline ran npm ci on Node 22 (npm 10), which rejected a lockfile generated by npm 11 because it lacked @emnapi/core and @emnapi/runtime (optional peers of @napi-rs/wasm-runtime). - Regenerate package-lock.json so it is valid for both npm 10 and npm 11 - Use Node 24 in ESRPSign and CI workflows to match local development - Use npm ci in CI workflows so lockfile drift is caught on PRs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd8bd799-c48f-44dd-a0b2-1ee61043fecc
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the focused lockfile repair or consistent workflow updates.
0 open findings
What changed in this PR
Fixes the signing pipeline’s lockfile mismatch and aligns CI with Node 24.
Changes:
- Adds missing optional peer dependencies and refreshes lockfile metadata.
- Moves signing and platform CI workflows to Node 24.
- Uses
npm ciin platform CI to catch lockfile drift.
| File | Description |
|---|---|
| package-lock.json | Adds missing dependencies and updates peer metadata. |
| .github/workflows/ESRPSign.yml | Uses Node 24 for signing. |
| .github/workflows/CI_windows.yml | Uses Node 24 and npm ci. |
| .github/workflows/CI_mac.yml | Uses Node 24 and npm ci. |
| .github/workflows/CI_linux.yml | Uses Node 24 and npm ci. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ESRP signing pipeline failed at
npm ci:The pipeline used Node 22 (npm 10), while the lockfile was generated with npm 11. npm 11 leaves out these optional peer dependencies of
@napi-rs/wasm-runtime, and npm 10'snpm cirejects the lockfile without them.Changes
package-lock.jsonso it passesnpm cion both npm 10 and npm 11.ESRPSign.ymland the CI workflows for Linux, Mac and Windows from Node 22.x to Node 24.x, to match local development.npm installtonpm ciso lockfile drift is caught on PRs.Validation
npx npm@10 ci.npm ci --dry-runpasses with npm 10 and npm 11.npm ciandnpm run build-and-lintpass on Node 24.