Repository navigation
fix(http-client-csharp): remove unsupported playground build flag - #12512
Merged
Jorge Rangel (jorgerangel-msft) merged 2 commits intoNov 7, 2026
Merged
Jorge Rangel (jorgerangel-msft) merged 2 commits into
Jorge Rangel (jorgerangel-msft) merged 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot CLI created this pull request from a session on behalf of
Jorge Rangel (jorgerangel-msft)
November 6, 2026 20:14
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
commit: |
JoshLove-msft
approved these changes
Nov 6, 2026
Jorge Rangel (jorgerangel-msft)
marked this pull request as ready for review
November 6, 2026 21:06
Jorge Rangel (jorgerangel-msft)
requested review from
Alan Zimmer (alzimmermsft),
Jose Arriaga Maldonado (joseharriaga) and
m-nash
as code owners
November 6, 2026 21:06
Alan Zimmer (alzimmermsft)
approved these changes
Nov 6, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deployment test no longer guards against reintroducing the CI-breaking --no-cache flag and lacks assertions for the ACR registry/image arguments.
1 open issue
What changed in this PR
Removes the unsupported --no-cache option from the C# playground server’s Azure container build command to address the reported CI failure.
Changes:
- Updates the shared deployment helper’s
az acr buildinvocation. - Removes the test assertion requiring
--no-cache; deployment retries, timeouts, and image verification remain unchanged.
| File | Description |
|---|---|
packages/http-client-csharp/playground-server/deploy.sh |
Removes --no-cache from the container build command. |
packages/http-client-csharp/playground-server.Tests/deploy.node-test.mjs |
Removes the assertion requiring the unsupported flag. |
Review effort: Balanced
Jorge Rangel (jorgerangel-msft)
enabled auto-merge
November 6, 2026 22:37
Jorge Rangel (jorgerangel-msft)
deleted the
fix/csharp-playground-azure-cli-options
branch
November 7, 2026 01:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remove
--no-cachefrom the C# playground server'saz acr buildcommand. The Azure CLI 2.91.0 installation used in CI rejects the option withERROR: unrecognized arguments: --no-cache, causing the build/deployment step introduced in #12497 to exit with code 2.Update the deployment test mock to reject the unsupported option and assert that the build still targets the expected registry and image. Existing deployment timeouts, retries, and live-image verification are unchanged.
Validation