Repository navigation
fix: escape pipes in HTML-derived table cells - #2823
Open
Dheeraj Piduru (DheerajPiduru52) wants to merge 1 commit into
Open
Dheeraj Piduru (DheerajPiduru52) wants to merge 1 commit into
Dheeraj Piduru (DheerajPiduru52) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Pipes inside <td>/<th> text were emitted verbatim, so a cell such as 'a|b' split into an extra column and corrupted the Markdown table. HTML, XLSX, XLS and DOCX tables all go through _CustomMarkdownify, so all of them were affected; the CSV converter already escapes pipes. Escape pipes (doubling any preceding backslash run) in convert_td and convert_th, mirroring the CSV converter.
Dheeraj Piduru (DheerajPiduru52)
force-pushed
the
fix/escape-pipes-in-table-cells
branch
from
November 3, 2026 21:12
c38bdfb to
003cc2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipes inside / text were emitted verbatim, so a cell such as 'a|b' split into an extra column and corrupted the Markdown table. HTML, XLSX, XLS and DOCX tables all go through _CustomMarkdownify, so all of them were affected; the CSV converter already escapes pipes.
Escape pipes (doubling any preceding backslash run) in convert_td and convert_th, mirroring the CSV converter.
Repro: an XLSX with a cell
a|bproduces| a|b | c |(3 columns under a 2-column header). Adds HTML and XLSX regression tests that fail without the fix and pass with it.