Repository navigation
fix(aiclient): count Claude streaming usage once - #3247
Open
alexcastgonz (pcbeingused333) wants to merge 1 commit into
Open
alexcastgonz (pcbeingused333) wants to merge 1 commit into
alexcastgonz (pcbeingused333) wants to merge 1 commit into
Conversation
The Messages stream decoder emitted usage on both message_start and message_delta, so TokenCounter and usage callbacks added the input tokens twice. Keep the message_start usage and emit one combined usage on message_delta.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude (Messages API) streaming token usage and cost were counted twice.
Root cause
MessagesWireApiProvider's stream decoder returned a usage piece for bothmessage_start(input/cache counts, output ≈ 1) andmessage_delta(cumulative output). The streaming loop inopenai.tsadds every piece's usage toTokenCounterand the usage callback, so Claude streams counted the input (and cache) tokens twice, inflating token totals and cost.Fix
The decoder remembers the
message_startusage and emits a single combined usage onmessage_delta(input/cache from the start event unless the delta supplies them, output from the delta).Test
Added a decoder test in
providerAdapter.spec.tsfeedingmessage_startthenmessage_delta: no usage on start, one combined usage on delta. Fails before the change (usage emitted on start), passes after.This change was prepared with the assistance of an AI coding agent (Claude).