fix(cmind): separate AI execution authority from repository config and align workflows - #99
Open
Qingtao Li (QingtaoLi1) wants to merge 4 commits into
Open
Qingtao Li (QingtaoLi1) wants to merge 4 commits into
Qingtao Li (QingtaoLi1) wants to merge 4 commits into
Conversation
Bonytu
previously approved these changes
Sep 22, 2026
Qingtao Li (QingtaoLi1)
dismissed
Bonytu’s stale review
September 22, 2026 11:01
No enough permission
Qingtao Li (QingtaoLi1)
requested review from
Bonytu
and removed request for
HYS (HuYaSen)
September 22, 2026 11:01
HYS (HuYaSen)
approved these changes
Sep 23, 2026
Require explicit user-local or trusted process provider selection, construct closed CLI invocations, and support known Windows npm entry points without shell wrappers. Make Git hooks opt-in and sync-only, retain provider permission checks, and gate releases on isolated security regressions and artifact checks.
Update multilingual onboarding, local provider selection and migration guidance, opt-in sync hooks, Windows npm compatibility, and approval-aware command templates. Correct CLI help and permission messaging without changing control flow; document the separate Release ZIP permission scope.
Validate directory-entry operations without resolving the final symlink while retaining target checks for content writes. Add sandbox boundary and cleanup regressions, and correct Markdown lint errors in the Windows UTF-8 repro guide.
Resolve product tools outside the workspace, pin CLI self-invocation and use trusted assets for initial encoding. Validate all sh/ps release ZIPs and add isolated execution regressions.
Qingtao Li (QingtaoLi1)
force-pushed
the
qingtaoli/fix_security_issue
branch
from
September 23, 2026 09:39
7f22eb1 to
4fc67cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separate repository-provided AI recommendations from execution authority, add shell-free Windows installation adapters, and align onboarding, migration guidance, and command templates with the new behavior.
Implementation
recommended_providerand validated legacyai_provider/ai_cli_cmdvalues as repository hints only.--aipreserve existing selection and never infer execution consent.Documentation and command templates
Compatibility
Validation
An additional planner-test run exposed an existing assertion mismatch:
test_warning_is_treated_as_incompleteexpectstype=warning, while the unchanged implementation returns a more descriptive warning reason. This unrelated issue was not modified.Remaining validation