Skip to content

fix(cmind): separate AI execution authority from repository config and align workflows - #99

Open
Qingtao Li (QingtaoLi1) wants to merge 4 commits into
mainfrom
qingtaoli/fix_security_issue
Open

Qingtao Li (QingtaoLi1) wants to merge 4 commits into
mainfrom
qingtaoli/fix_security_issue

Conversation

@QingtaoLi1

Copy link
Copy Markdown
Contributor

Summary

Separate repository-provided AI recommendations from execution authority, add shell-free Windows installation adapters, and align onboarding, migration guidance, and command templates with the new behavior.

Implementation

  • Treat recommended_provider and validated legacy ai_provider / ai_cli_cmd values as repository hints only.
  • Require an explicit caller choice, trusted process/CI environment, or user-local provider selection bound to the canonical workspace path.
  • Save local selection only after successful setup. Updates without --ai preserve existing selection and never infer execution consent.
  • Construct process arguments from a closed provider table; reject arbitrary commands, paths, additional arguments, and malformed configuration.
  • Support native Windows executables and recognized Claude/Copilot npm entry points without executing shell wrappers.
  • Make Git hooks opt-in and synchronization-only; remove background AI updates and reconcile recognized legacy hook blocks.
  • Remove default provider permission-bypass flags.
  • Preserve the newer main branch's Windows UTF-8, process-tree cleanup, and diagnostic agent-detection behavior without allowing detection to authorize execution.
  • Add isolated regressions and release gates for source, installed-wheel, and Release ZIP checks.

Documentation and command templates

  • Update the root README and all five CoderMind language guides.
  • Document explicit initialization, local selection, migration, Windows compatibility, and opt-in hooks.
  • Correct storage-layout, CLI help, and permission messaging.
  • Update all 15 command templates to surface configuration/authentication/access/approval blockers and pause rather than automatically changing settings or retrying.
  • Clarify that independent Release ZIP templates can still contain broader Claude permissions; removing CLI bypass flags does not revoke existing grants.

Compatibility

  • New clones, moved workspaces, and new users require explicit local selection or trusted process/CI configuration.
  • Valid repository hints may remain tracked but no longer authorize execution.
  • Arbitrary custom commands and script wrappers are unsupported.
  • AI-driven graph updates require explicit invocation; normal provider approvals may interrupt unattended workflows.

Validation

  • Focused isolated security and template regressions: 812 passed, 41 skipped, 5 deselected.
  • Markdown structure, template frontmatter, new relative links/anchors, and whitespace checks passed.
  • AST comparison confirmed the documentation follow-up changed CLI text/comments only.
  • No real AI CLI was installed or executed; developer-machine settings and actual Git hooks were unchanged.

An additional planner-test run exposed an existing assertion mismatch: test_warning_is_treated_as_incomplete expects type=warning, while the unchanged implementation returns a more descriptive warning reason. This unrelated issue was not modified.

Remaining validation

  • Run remote Linux/Windows CI and installed-artifact checks.
  • Verify real supported CLI installations in an isolated environment.
  • Complete the original-report retest before considering the incident resolved.

Bonytu
Bonytu previously approved these changes Sep 22, 2026
@QingtaoLi1
Qingtao Li (QingtaoLi1) requested review from Bonytu and removed request for HYS (HuYaSen) September 22, 2026 11:01
Require explicit user-local or trusted process provider selection, construct closed CLI invocations, and support known Windows npm entry points without shell wrappers. Make Git hooks opt-in and sync-only, retain provider permission checks, and gate releases on isolated security regressions and artifact checks.
Update multilingual onboarding, local provider selection and migration guidance, opt-in sync hooks, Windows npm compatibility, and approval-aware command templates. Correct CLI help and permission messaging without changing control flow; document the separate Release ZIP permission scope.
Validate directory-entry operations without resolving the final symlink while retaining target checks for content writes. Add sandbox boundary and cleanup regressions, and correct Markdown lint errors in the Windows UTF-8 repro guide.
Resolve product tools outside the workspace, pin CLI self-invocation and use trusted assets for initial encoding. Validate all sh/ps release ZIPs and add isolated execution regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants