[PIX] Add validation support to PIX pass tests - #8841
Open
Damyan Pepper (damyanp) wants to merge 1 commit into
Open
[PIX] Add validation support to PIX pass tests#8841Damyan Pepper (damyanp) wants to merge 1 commit into
Damyan Pepper (damyanp) wants to merge 1 commit into
Conversation
The PIX passes change DXIL after the compiler completes. A pass can add a resource, change a root signature, insert an operation, and remove a declaration. The result can be a module that the validator refuses. The tests only examine the disassembly, so they cannot find this type of defect. The new helpers run the DXIL validator on the output of a pass. They also separate the diagnostics that PIX instrumentation is permitted to cause from the diagnostics that are defects. The set of permitted diagnostics decides what every later layer can ignore, so it is the part to examine with care. There is no change to the compiler. Assisted-by: Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40dc9de3-617e-4caf-ab0d-fba0a033ed93
Damyan Pepper (damyanp)
requested a review
from Austin Kinross (austinkinross)
August 27, 2026 21:05
Damyan Pepper (damyanp)
force-pushed
the
users/damyanp/pix-fixes-01
branch
from
August 27, 2026 21:08
a947233 to
5238ee0
Compare
Damyan Pepper (damyanp)
marked this pull request as ready for review
August 27, 2026 22:43
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a validation harness for PIX pass test outputs.
Changes:
- Adds single-pass execution and DXIL validation helpers.
- Filters permitted PIX metadata diagnostics.
- Adds control tests for valid and invalid outputs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3711
to
+3713
| FilteredValidationDiagnostics realDiagnostic = | ||
| GetSignificantValidationDiagnostics("Validation failed.\n" | ||
| "Some real validator diagnostic.\n"); |
Comment on lines
+361
to
+363
| if (line.find("All metadata must be used by dxil") != std::string::npos) { | ||
| result.PermittedExceptionCount++; | ||
| continue; |
Austin Kinross (austinkinross)
approved these changes
Aug 27, 2026
Joshua Batista (bob80905)
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PIX passes change DXIL after the compiler completes. A pass can add a resource, change a root signature, insert an operation, and remove a declaration. The result can be a module that the validator refuses. The tests only examine the disassembly, so they cannot find this type of defect.
The new helpers run the DXIL validator on the output of a pass. They also separate the diagnostics that PIX instrumentation is permitted to cause from the diagnostics that are defects. The set of permitted diagnostics decides what every later layer can ignore, so it is the part to examine with care.
There is no change to the compiler.
Assisted-by: Copilot
Stack created with GitHub Stacks CLI • Give Feedback 💬