Fix concurrent dxilconv pass initialization - #8820
Draft
Damyan Pepper (damyanp) wants to merge 2 commits into
Draft
Fix concurrent dxilconv pass initialization#8820Damyan Pepper (damyanp) wants to merge 2 commits into
Damyan Pepper (damyanp) wants to merge 2 commits into
Conversation
Register all passes used by the DXBC converter during DLL startup. Add fresh-process tests for the pass closure and concurrent conversion. Fixes microsoft#8819 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1147c945-f9cc-4aa3-8f58-e7238e0270ec
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1147c945-f9cc-4aa3-8f58-e7238e0270ec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register all passes that dxilconv uses when the DLL starts. This prevents concurrent first conversions from modifying the global pass registry.
Add fresh-process tests that verify pass registration and convert 256 different DXBC shaders at the same time.
Fixes #8819