Preserve latest tag when publishing historical typings - #1335
Preserve latest tag when publishing historical typings#1335Jake Bailey (jakebailey) with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
|
Copilot what happens to preexisting broken packages? See the node package on the registry |
They are not repaired by the normal publisher unless another historical version is published. The existing weekly |
|
Copilot changesets should not mention private packages, and ci is failing formatting |
There was a problem hiding this comment.
🟢 Approval recommended
The explicit tag handling and cleanup behavior are consistent, complete, and adequately covered by regression tests.
Pull request overview
Ensures historical typings no longer overwrite npm’s latest tag.
Changes:
- Requires explicit publication tags.
- Uses
latest,old-version, andnextappropriately. - Removes temporary historical tags with non-fatal cleanup handling and regression tests.
File summaries
| File | Description |
|---|---|
packages/utils/src/npm.ts |
Adds explicit publish tags and tag removal support. |
packages/publisher/src/lib/package-publisher.ts |
Tags current and historical typings appropriately. |
packages/publisher/src/publish-registry.ts |
Explicitly publishes the registry under next. |
packages/publisher/test/package-publisher.test.ts |
Tests tagging, cleanup ordering, and cleanup failures. |
.changeset/tidy-tags-rest.md |
Records patch releases. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Publishing changes shared by multiple versions could leave npm’s
latesttag pointing to the last historical version published.Make publication intent explicit
NpmPublishClient.publishcall to specify a tag.latest, historical typings asold-version, and the registry asnext.Protect
latestlatestcorrection.