Skip to content

Added host container query param to designer site - #8548

Closed
J. Diego Rodríguez Royo (Diegorro98) wants to merge 2 commits into
microsoft:mainfrom
Diegorro98:host_container_query_param
Closed

Added host container query param to designer site#8548
J. Diego Rodríguez Royo (Diegorro98) wants to merge 2 commits into
microsoft:mainfrom
Diegorro98:host_container_query_param

Conversation

@Diegorro98

@Diegorro98 J. Diego Rodríguez Royo (Diegorro98) commented Jun 10, 2023

Copy link
Copy Markdown

Description

This PR allows to set a host container by using a query param. This query param should be a number that represents the index on CardDesigner._hostContainers array (and the index at Host App Choice Picker at the designer's UI).

To do that I created a function that checks that the index is on the valid range and then applies it.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit tests that were added if any. If none were added please add a quick line explaining why not.
    No tests were added, I didn't know where are CardDesigner class tests.

I was able to test that the query param works with this url: https://adaptivecards.io/designer?hostContainerIndex=1 but I wasn't able to make work the designer because although I tried to set up the development environment with this instructions and this workaround

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi J. Diego Rodríguez Royo (@Diegorro98). This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

1 similar comment
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi J. Diego Rodríguez Royo (@Diegorro98). This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Staleness reset by anna-dingler

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi J. Diego Rodríguez Royo (@Diegorro98). This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

2 similar comments
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi J. Diego Rodríguez Royo (@Diegorro98). This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hi J. Diego Rodríguez Royo (@Diegorro98). This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@Diegorro98

Copy link
Copy Markdown
Author

Closing this PR because I made a new PR (#8850) with more query params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants