Skip to content

fixes #2045 - #2046

Merged
affeldt-aist merged 2 commits into
math-comp:masterfrom
affeldt-aist:fixes_2045
Jul 24, 2026
Merged

fixes #2045#2046
affeldt-aist merged 2 commits into
math-comp:masterfrom
affeldt-aist:fixes_2045

Conversation

@affeldt-aist

Copy link
Copy Markdown
Member
Motivation for this change

fixes #2045

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Jul 22, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jul 22, 2026
@affeldt-aist

Copy link
Copy Markdown
Member Author

could you take a look at this PR @amolinamounier ?

@amolinamounier amolinamounier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason cst_continuous and within_continuous_cst couldn't be automatic hints as well? Looks good otherwise.

@affeldt-aist

Copy link
Copy Markdown
Member Author

Is there any particular reason cst_continuous and within_continuous_cst couldn't be automatic hints as well? Looks good otherwise.

As of today, no strong reason I suspect. I think that in the past we have been cautious not to add too many hints by fear of future performance issues. We never came up with a policy regarding hints.

Regarding, cst_continuous/cst_within_continuous vs. cvg_cst/is_cvg_cst: the former is not used as much as the latter, and the latter is more primitive (in particular, {within _, continuous _} is perfectible). For these reasons, it is urgent to fix the automation of cvg_cst while cst_continuous could maybe wait and be the topic of another PR that could explore a bit more systematic way to introduce such hints (hints for obvious, dangling subgoals) and come with a principled policy for it (maybe motivated by performance measurements, using Rocq tools (see https://rocq-prover.org/doc/V9.2.0/refman/practical-tools/utilities.html#timing-targets-and-performance-testing).

@affeldt-aist affeldt-aist added the "bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug" label Jul 23, 2026
@affeldt-aist

Copy link
Copy Markdown
Member Author

Maybe let's merge and defer the question about cst_{within_,}continuous to an issue?

@affeldt-aist
affeldt-aist merged commit 1024276 into math-comp:master Jul 24, 2026
41 of 45 checks passed
@affeldt-aist
affeldt-aist deleted the fixes_2045 branch July 24, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

"bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug" enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hint Resolve cvg_cst is ineffective

2 participants