fix: ABS "mark existing books as downloaded" toggle has no effect (#222)#223
Open
LeDomme wants to merge 1 commit into
Open
fix: ABS "mark existing books as downloaded" toggle has no effect (#222)#223LeDomme wants to merge 1 commit into
LeDomme wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: ABS "mark existing books as downloaded" check never invoked
Closes #222
Problem
abs_mark_downloaded_flagswas implemented inapp/internal/audiobookshelf/client.pybut never called from the search route, making the "Use ABS to mark existing books as downloaded" toggle completely non-functional.Fix
Call
abs_mark_downloaded_flagsinsearch_booksafter merging the Audible results, so existing books are checked against ABS and marked as downloaded before the response is returned.Changes
app/routers/api/search.py: import and invokeabs_mark_downloaded_flagsafter building the merged result list