Repository navigation
fix: correct SQLite column metadata types - #313
Merged
chrispader merged 2 commits intoSep 29, 2026
Merged
Conversation
Compare declared SQLite types for equality and cover sync and async metadata mapping. Closes margelo#305.
This was referenced Sep 10, 2026
|
@chrispader is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite query metadata assigns the wrong types to declared columns because the native mapper treats unequal type names as matches. This makes most declarations appear as
BOOLEANand makesBOOLEANappear asNUMBER, which can mislead consumers that use metadata. This change compares declaration names for equality and adds database-backed regression tests forexecute()andexecuteAsync().The mapping still recognizes only exact
BOOLEAN,FLOAT,INTEGER,TEXT, andBLOBdeclarations. Other declarations, includingREAL,DOUBLE,VARCHAR(...), andINT, continue to returnNULL_VALUE.Reproduction
Create a table with columns declared as
BOOLEAN,FLOAT,INTEGER,TEXT, andBLOB. Select those columns plusNULL AS null_value, then inspectresult.metadata. Before the fix, the boolean column reportsNUMBERand the other declared columns reportBOOLEAN. After the fix, the six metadata types areBOOLEAN,NUMBER,INT64,TEXT,ARRAY_BUFFER, andNULL_VALUE, respectively.Closes #305.