Skip to content

fix(animated-theme-toggler): prevent compositor crashes - #996

Merged
Yeom-JinHo merged 4 commits into
magicuidesign:mainfrom
GamerJagdish:prevent-compositer-crash
Aug 11, 2026
Merged

fix(animated-theme-toggler): prevent compositor crashes#996
Yeom-JinHo merged 4 commits into
magicuidesign:mainfrom
GamerJagdish:prevent-compositer-crash

Conversation

@GamerJagdish

Copy link
Copy Markdown
Contributor

Description

These changes prevents compositor crash on rapid click.

Changes

  • Add activeAnimRef to track and manage ongoing clip-path animations
  • Implement cancelAnim callback to properly cancel active animations before starting new transitions
  • Cancel animations when entering transition state to prevent animation conflicts
  • Store animation reference when starting new clip-path animation

Motivation

I had this issue for a bit and saw it mentioned in #986 which then got an update in #987 but it was still crashing it so i fixed it.

Breaking Changes

none

Checklist

  • pnpm check passes locally
  • pnpm build passes locally
  • pnpm build:registry was run and the generated files are committed (if you changed registry/ or config/site.ts — CI verifies this on every PR)
  • PR title follows Conventional Commits (e.g., feat(marquee): add reverse prop)

- Add activeAnimRef to track and manage ongoing clip-path animations
- Implement cancelAnim callback to properly cancel active animations before starting new transitions
- Cancel animations when entering transition state to prevent animation conflicts
- Store animation reference when starting new clip-path animation
@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

@GamerJagdish is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo
Yeom-JinHo self-requested a review August 9, 2026 23:48
@Yeom-JinHo

Copy link
Copy Markdown
Member

@GamerJagdish
Thanks fro the work here!
I've pushed a few follow-up commits to your branch to address some issues i found during review

@Yeom-JinHo
Yeom-JinHo merged commit 2d671cc into magicuidesign:main Aug 11, 2026
6 of 7 checks passed
@GamerJagdish

Copy link
Copy Markdown
Contributor Author

@Yeom-JinHo
I will keep the exhaustive-deps in mind next time, thank you for the review! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants