Repository navigation
ci: point chart-testing at repo root so charts are actually linted - #170
Merged
Merged
Conversation
|
|
biglittlebigben
left a comment
biglittlebigben
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Can you fix the broken chart in the same PR?
biglittlebigben
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint/install workflow has been passing without testing any charts.
--chart-dirsexpects directories that contain chart directories, but it was given the chart directories themselves (egress ingress livekit-server). Soctfound no charts, as the log from the #167 run shows:This changes both
ct lintandct installto--chart-dirs ., soctfindsegress/,ingress/andlivekit-server/at the repo root.Expect this PR's CI to fail. That's the check working.
egress/Chart.yamlonmasterhas an unterminated quote from #167 (appVersion: "v1.14.1), which isn't valid YAML. The chart fix is being kept separate from this PR. Lint or install may also turn up other problems that have been hidden until now.