fix(adk): repair PostgreSQL vector memory search (#726) - #727
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
+ Coverage 76.95% 77.08% +0.13%
==========================================
Files 487 487
Lines 69755 69819 +64
Branches 9662 9676 +14
==========================================
+ Hits 53677 53819 +142
+ Misses 12643 12541 -102
- Partials 3435 3459 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL ADK memory stores omitted persisted embeddings and bound vector operands in a form that required optional pgvector client codecs. BM25 capability detection also relied on
pg_searchalthough the index and operator requirepg_textsearch.This persists nullable embeddings and casts PostgreSQL vector bindings through
float8[], applies the cast to vector and hybrid searches, and validates cachedpg_textsearchcapability before BM25 DDL or queries.Fixes #726