Repository navigation
Conversation
Contributor
|
I am a bot, here is the pushed image/manifest for this PR for commit 51b1445 :
|
Closed
thelamer
approved these changes
Aug 16, 2026
github-project-automation
Bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Latest upstream release breaks any uploads that aren't under the upload folder hierarchy in /app/data to prevent path traversal attacks, so symlinks won't work any more. Instead we can update the sails config at init to set our own upload root, so that the checks will pass.
Logs symlink is still fine.
Also updated local build version checks to use jq
Benefits of this PR and context:
How Has This Been Tested?
Source / References: