Skip to content

fix: do not stop dde-daemon service on upgrade - #1220

Merged
fly602 merged 1 commit into
linuxdeepin:masterfrom
fly602:master
Aug 20, 2026
Merged

fix: do not stop dde-daemon service on upgrade#1220
fly602 merged 1 commit into
linuxdeepin:masterfrom
fly602:master

Conversation

@fly602

@fly602 fly602 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

When upgrading the dde-daemon package, the service should not be stopped to avoid compatibility issues. Added --no-stop-on-upgrade option to dh_installsystemd to prevent service interruption during upgrades.

Log: Fixed service stopping during dde-daemon upgrade

Influence:

  1. Verify that dde-daemon is not stopped during package upgrade
  2. Check that the service remains functional after upgrade
  3. Test upgrade from previous version to new version
  4. Confirm no compatibility issues arise from service restart

fix: 升级dde-daemon时不停止服务

升级dde-daemon软件包时不应停止服务,以避免兼容性问题。为
dh_installsystemd添加--no-stop-on-upgrade选项,防止升级过程中服务 中断。

Log: 修复升级dde-daemon时服务被停止的问题

Influence:

  1. 验证软件包升级过程中dde-daemon服务不会被停止
  2. 确认升级后服务仍然正常运行
  3. 测试从旧版本升级到新版本的过程
  4. 确保不会因重启服务引发兼容性问题

PMS: TASK-393313

Summary by Sourcery

Keep dde-daemon running while upgrading its package.

Bug Fixes:

  • Prevent stopping the dde-daemon service during package upgrades to maintain service availability and avoid upgrade-related compatibility issues.

Build:

  • Update Debian packaging to preserve dde-daemon service continuity during upgrades.

When upgrading the dde-daemon package, the service should not be stopped
to avoid compatibility issues. Added `--no-stop-on-upgrade` option to
`dh_installsystemd` to prevent service interruption during upgrades.

Log: Fixed service stopping during dde-daemon upgrade

Influence:
1. Verify that dde-daemon is not stopped during package upgrade
2. Check that the service remains functional after upgrade
3. Test upgrade from previous version to new version
4. Confirm no compatibility issues arise from service restart

fix: 升级dde-daemon时不停止服务

升级dde-daemon软件包时不应停止服务,以避免兼容性问题。为
`dh_installsystemd`添加`--no-stop-on-upgrade`选项,防止升级过程中服务
中断。

Log: 修复升级dde-daemon时服务被停止的问题

Influence:
1. 验证软件包升级过程中dde-daemon服务不会被停止
2. 确认升级后服务仍然正常运行
3. 测试从旧版本升级到新版本的过程
4. 确保不会因重启服务引发兼容性问题

PMS: TASK-393313
@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the --no-stop-on-upgrade flag to dh_installsystemd in debian/rules so the dde-daemon systemd service is not stopped during package upgrades, preventing compatibility issues.

File-Level Changes

Change Details Files
Prevent dde-daemon systemd service from being stopped during package upgrade.
  • Updated debian packaging rules to pass --no-stop-on-upgrade to dh_installsystemd.
  • Ensured systemd unit for dde-daemon remains active across package upgrades to avoid compatibility-related restarts.
debian/rules

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:95分

■ 【总体评价】

代码通过添加--no-stop-on-upgrade参数正确修复了服务在升级时被意外停止的问题
逻辑正确且符合规范,因缺乏上下文注释微扣5分

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

debian/rules 文件中的 override_dh_installsystemd 目标正确使用了 dh_installsystemd 命令,并追加了 --no-stop-on-upgrade 参数,Makefile 语法无误。
潜在问题:无
建议:无

  • 2.代码质量(良好)✓

修改直接定位问题,添加的参数有效阻止了升级时的服务中断,符合 Debian 打包规范。
潜在问题:缺少对为何添加该参数的注释说明,未来维护者可能不清楚其背景。
建议:在 override_dh_installsystemd 上方添加简短注释说明使用 --no-stop-on-upgrade 的原因。

  • 3.代码性能(无性能问题)✓

仅修改构建打包阶段的命令参数,不涉及运行时性能影响。
潜在问题:无
建议:无

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次代码修改仅涉及打包配置参数调整,未引入任何外部输入处理或危险函数调用,不存在安全风险。

  • 建议:无需安全修复

■ 【改进建议代码示例】

# 避免在包升级时停止服务,从而防止服务中断
override_dh_installsystemd:
	dh_installsystemd --no-start --no-stop-on-upgrade
 
 override_dh_auto_clean:
 	dh_auto_clean --

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602
fly602 merged commit df0ad9d into linuxdeepin:master Aug 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants