Skip to content

chore: bump version to 6.1.103 - #1217

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:automation/update-changelog/6.1.103-20260819090957
Aug 19, 2026
Merged

chore: bump version to 6.1.103#1217
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:automation/update-changelog/6.1.103-20260819090957

Conversation

@mhduiy

@mhduiy mhduiy commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Update debian/changelog to 6.1.103.

Summary by Sourcery

Build:

  • Bump the Debian package version to 6.1.103.

update changelog to 6.1.103

Log: update changelog to 6.1.103
@sourcery-ai

sourcery-ai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Debian package changelog to reflect a new release version 6.1.103.

File-Level Changes

Change Details Files
Update recorded package version to 6.1.103 in the Debian changelog.
  • Modify the topmost changelog entry to use version 6.1.103.
  • Ensure the changelog format remains compliant with Debian standards.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:40分

■ 【总体评价】

提交仅包含变更日志,完全缺失核心修复代码,无法解决安全启动提权弹窗问题
逻辑与质量严重缺失且存在高危安全漏洞,按规则强制降分至40分

■ 【详细分析】

  • 1.语法逻辑(存在致命错误)✕

本次提交仅修改了debian/changelog文件,未包含任何实际的C++/Go源码变更。作为修复未适配安全启动应用调用接口弹出提权弹窗的提交,缺失在polkit权限校验或DBus接口调用前增加安全启动检测的核心逻辑,属于未完成实现的致命错误。
潜在问题:编译后不会产生任何行为变化,BUG依然百分百复现;缺乏函数实现导致模块功能断裂。
建议:补充src/system/或src/polkit/目录下的具体源码修改,实现安全启动状态读取与提权请求拦截逻辑。

  • 2.代码质量(存在严重问题)✕

提交内容不完整,不符合基本的代码提交规范。一个缺陷修复提交必须包含对应的问题解决代码,仅更新日志属于无效提交。
潜在问题:变更集不闭环;无任何代码注释说明安全启动判断条件。
建议:完善提交内容,确保changelog记录与实际代码修改同步提交。

  • 3.代码性能(无性能问题)✓

由于未提供实际业务逻辑代码,不产生额外的系统调用或算法开销,无性能问题。
建议:在后续补充代码时,注意安全启动状态检测应采用缓存机制,避免每次DBus调用都重复读取系统文件导致IO性能下降。

  • 4.代码安全(存在 1 个安全漏洞(高危1个))✕

漏洞对比统计:新增漏洞 1 个,减少漏洞 0 个,持平 0 个
由于核心修复代码缺失,原有的安全启动策略绕过风险未被消除,攻击面依然存在于DBus接口的权限校验环节。

  • 安全漏洞1(高危):权限绕过/策略失效 在 dde-daemon 权限控制/安全启动相关逻辑模块中,由于缺失对当前系统是否开启安全启动的检测,未适配安全启动的恶意应用仍可正常触发polkit提权弹窗,攻击者可通过社会工程学或自动化脚本诱导用户点击授权,从而在安全启动环境下获取未授权的系统高权限 ——非常重要

  • 建议:在DBus接口的入口处增加安全启动状态校验,若检测到相关efi变量开启且调用方进程未在安全启动适配白名单中,则直接拒绝请求或静默失败,不调用polkit鉴权接口。

■ 【改进建议代码示例】

// 假设在 src/system/system_manager.cpp 或相关权限管理文件中
// 增加安全启动状态检测与过滤逻辑
#include <fstream>
#include <string>

bool IsSecureBootEnabled() {
    std::ifstream file("/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c", std::ios::binary);
    if (!file.is_open()) {
        return false;
    }
    char buf[4];
    if (file.read(buf, 4)) {
        return buf[3] == 1;
    }
    return false;
}

bool IsAppAdaptedToSecureBoot(const std::string& appPath) {
    // 实现应用白名单校验或签名校验逻辑
    return false; 
}

// 在原有的DBus接口处理函数入口处调用
void HandleDBusMethodCall(...) {
    if (IsSecureBootEnabled()) {
        if (!IsAppAdaptedToSecureBoot(callerPath)) {
            // 静默拒绝,不抛出polkit提权弹窗
            return;
        }
    }
    
    // 原有的 polkit 校验及业务逻辑
}

@deepin-ci-robot

Copy link
Copy Markdown

@mhduiy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
github-pr-review-ci e1966ce link true /test github-pr-review-ci

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy

mhduiy commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

★ 总体评分:40分

■ 【总体评价】

提交仅包含变更日志,完全缺失核心修复代码,无法解决安全启动提权弹窗问题
逻辑与质量严重缺失且存在高危安全漏洞,按规则强制降分至40分

■ 【详细分析】

  • 1.语法逻辑(存在致命错误)✕

本次提交仅修改了debian/changelog文件,未包含任何实际的C++/Go源码变更。作为修复未适配安全启动应用调用接口弹出提权弹窗的提交,缺失在polkit权限校验或DBus接口调用前增加安全启动检测的核心逻辑,属于未完成实现的致命错误。
潜在问题:编译后不会产生任何行为变化,BUG依然百分百复现;缺乏函数实现导致模块功能断裂。
建议:补充src/system/或src/polkit/目录下的具体源码修改,实现安全启动状态读取与提权请求拦截逻辑。

  • 2.代码质量(存在严重问题)✕

提交内容不完整,不符合基本的代码提交规范。一个缺陷修复提交必须包含对应的问题解决代码,仅更新日志属于无效提交。
潜在问题:变更集不闭环;无任何代码注释说明安全启动判断条件。
建议:完善提交内容,确保changelog记录与实际代码修改同步提交。

  • 3.代码性能(无性能问题)✓

由于未提供实际业务逻辑代码,不产生额外的系统调用或算法开销,无性能问题。
建议:在后续补充代码时,注意安全启动状态检测应采用缓存机制,避免每次DBus调用都重复读取系统文件导致IO性能下降。

  • 4.代码安全(存在 1 个安全漏洞(高危1个))✕

漏洞对比统计:新增漏洞 1 个,减少漏洞 0 个,持平 0 个
由于核心修复代码缺失,原有的安全启动策略绕过风险未被消除,攻击面依然存在于DBus接口的权限校验环节。

  • 安全漏洞1(高危):权限绕过/策略失效 在 dde-daemon 权限控制/安全启动相关逻辑模块中,由于缺失对当前系统是否开启安全启动的检测,未适配安全启动的恶意应用仍可正常触发polkit提权弹窗,攻击者可通过社会工程学或自动化脚本诱导用户点击授权,从而在安全启动环境下获取未授权的系统高权限 ——非常重要
  • 建议:在DBus接口的入口处增加安全启动状态校验,若检测到相关efi变量开启且调用方进程未在安全启动适配白名单中,则直接拒绝请求或静默失败,不调用polkit鉴权接口。

■ 【改进建议代码示例】

// 假设在 src/system/system_manager.cpp 或相关权限管理文件中
// 增加安全启动状态检测与过滤逻辑
#include <fstream>
#include <string>

bool IsSecureBootEnabled() {
    std::ifstream file("/sys/firmware/efi/efivars/SecureBoot-8be4df61-93ca-11d2-aa0d-00e098032b8c", std::ios::binary);
    if (!file.is_open()) {
        return false;
    }
    char buf[4];
    if (file.read(buf, 4)) {
        return buf[3] == 1;
    }
    return false;
}

bool IsAppAdaptedToSecureBoot(const std::string& appPath) {
    // 实现应用白名单校验或签名校验逻辑
    return false; 
}

// 在原有的DBus接口处理函数入口处调用
void HandleDBusMethodCall(...) {
    if (IsSecureBootEnabled()) {
        if (!IsAppAdaptedToSecureBoot(callerPath)) {
            // 静默拒绝,不抛出polkit提权弹窗
            return;
        }
    }
    
    // 原有的 polkit 校验及业务逻辑
}

误报,当前仅修改changelog

@mhduiy
mhduiy merged commit c4b76e2 into linuxdeepin:master Aug 19, 2026
13 of 17 checks passed
@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.1.103
EXISTED: no
DISTRIBUTION: unstable

@deepin-bot

deepin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.1.103
  • Tag SHA: 6e3ebfd97f93663854b568a93c2457ff07eb40db
  • Commit SHA: c4b76e279f8a71fe9c601a6d3c46b68443cf0120
  • Tag Message:
    Release dde-daemon 6.1.103
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants