completions: regenerate from a complete Linux build - #3883
Open
jimmunn wants to merge 1 commit into
Open
Conversation
Picks up the --fast_io_fail_tmo -> --fast-io-fail-tmo rename and the new supported-pages command. The PowerShell completion was generated on Windows, which omits the Linux-only fabrics and plugin commands; regenerating on Linux restores them. Most of the bash/zsh diff is reordering to match the binary's command registration order. Signed-off-by: Jim Munn <jlmunn@micron.com>
Collaborator
Author
|
This does raise the question of whether completions for Windows should be generated in Windows or Linux. Currently, the Windows completions will include commands available in Linux but not available on Windows. However, all Windows commands will be included. |
Collaborator
|
Can you drop the generated bits? I'll run the generator with the release script. Just add the real change. Good question. These will be generated on my machine on release. I guess we need two build configuration for generating the completion correctly by extending the release.sh script accordingly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the --fast_io_fail_tmo -> --fast-io-fail-tmo rename and the new supported-pages command. The PowerShell completion was generated on Windows, which omits the Linux-only fabrics and plugin commands; regenerating on Linux restores them. Most of the bash/zsh diff is reordering to match the binary's command registration order.