Enable assert-util testing on windows using new shared spawn and wait utilities. - #3844
Merged
igaw merged 2 commits intoAug 17, 2026
Merged
Conversation
Adds shared utilities for spawning and waiting for processes, and for creating pipes. Includes Linux and Windows implementations. Signed-off-by: Broc Going <bgoing@micron.com>
…port Windows doesn't support fork. Change the test to re-invoke the test binary as a child process using shr_spawn. Enable the test on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
brgoing
changed the title
Collaborator
|
FWIW, when I was extending the test coverage I was not sure if it was worth to adding the process management functions. Well, we might need it somewhere else, so let's add them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows doesn't support fork, so the assert-util tests needed to be redesigned slightly to work across platforms.