nvme-print: fix to check init and finish functions - #3841
Open
ikegami-t wants to merge 1 commit into
Open
Conversation
Since basically nvme_print is skipped for dry-run. But some print functions not using nvme_print are not skipped. So the json_r object not created then the json print error caused. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
igaw
reviewed
Aug 17, 2026
| return false; | ||
|
|
||
| if (!nvme_args.dry_run) | ||
| return true; |
Collaborator
There was a problem hiding this comment.
I would change the order and also the logic slightly:
...
/*
* Always run init and the finish hooks to properly initialize the
* the output plugin.
*/
if (func == ops->show_init || func == ops->show_finish)
return true;
if (nvme_args.dry_run)
return false;
return true;This feels a bit more natural do read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since basically nvme_print is skipped for dry-run. But some print functions not using nvme_print are not skipped. So the json_r object not created then the json print error caused.