Skip to content

Purge standard includes promoted to system define. #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Sep 5, 2026
Merged

Purge standard includes promoted to system define. #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/bitcoin/node/channels/channel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_CHANNELS_CHANNEL_HPP
#define LIBBITCOIN_NODE_CHANNELS_CHANNEL_HPP

#include <memory>
#include <bitcoin/node/channels/channel.hpp>
#include <bitcoin/node/configuration.hpp>
#include <bitcoin/node/define.hpp>
Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/channels/channel_peer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_CHANNELS_CHANNEL_PEER_HPP
#define LIBBITCOIN_NODE_CHANNELS_CHANNEL_PEER_HPP

#include <memory>
#include <bitcoin/node/channels/channel.hpp>
#include <bitcoin/node/configuration.hpp>
#include <bitcoin/node/define.hpp>
Expand Down
3 changes: 0 additions & 3 deletions include/bitcoin/node/define.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
#define LIBBITCOIN_NODE_DEFINE_HPP

/// Standard includes (do not include directly).
#include <memory>
#include <utility>
#include <variant>

/// Pulls in common /node headers (excluding settings/config/full_node).
#include <bitcoin/node/chase.hpp>
Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/estimator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#define LIBBITCOIN_NODE_ESTIMATOR_HPP

#include <atomic>
#include <memory>
#include <bitcoin/node/define.hpp>

namespace libbitcoin {
Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/impl/chasers/chaser_organize.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_CHASERS_CHASER_ORGANIZE_IPP
#define LIBBITCOIN_NODE_CHASERS_CHASER_ORGANIZE_IPP

#include <algorithm>
#include <ranges>
#include <bitcoin/node/chasers/chaser.hpp>
#include <bitcoin/node/define.hpp>
Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/protocols/protocol.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_HPP
#define LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_HPP

#include <memory>
#include <bitcoin/node/channels/channels.hpp>
#include <bitcoin/node/configuration.hpp>
#include <bitcoin/node/define.hpp>
Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/protocols/protocol_filter_out_70015.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_CLIENT_FILTER_HPP
#define LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_CLIENT_FILTER_HPP

#include <memory>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/protocols/protocol_peer.hpp>

Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/protocols/protocol_observer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_OBSERVER_HPP
#define LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_OBSERVER_HPP

#include <memory>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/protocols/protocol.hpp>
#include <bitcoin/node/protocols/protocol_peer.hpp>
Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/protocols/protocol_peer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#ifndef LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_PEER_HPP
#define LIBBITCOIN_NODE_PROTOCOLS_PROTOCOL_PEER_HPP

#include <memory>
#include <bitcoin/node/channels/channels.hpp>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/protocols/protocol.hpp>
Expand Down
2 changes: 0 additions & 2 deletions include/bitcoin/node/sessions/session_peer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
#ifndef LIBBITCOIN_NODE_SESSIONS_SESSION_PEER_HPP
#define LIBBITCOIN_NODE_SESSIONS_SESSION_PEER_HPP

#include <memory>
#include <utility>
#include <bitcoin/node/channels/channels.hpp>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/protocols/protocols.hpp>
Expand Down
1 change: 0 additions & 1 deletion src/block_arena.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/block_arena.hpp>

#include <algorithm>
#include <bitcoin/node/define.hpp>

namespace libbitcoin {
Expand Down
1 change: 0 additions & 1 deletion src/channels/channel_peer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/channels/channel_peer.hpp>

#include <algorithm>
#include <bitcoin/node/configuration.hpp>
#include <bitcoin/node/define.hpp>

Expand Down
1 change: 0 additions & 1 deletion src/chasers/chaser_block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/chasers/chaser_block.hpp>

#include <algorithm>
#include <bitcoin/node/chasers/chaser_organize.hpp>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/full_node.hpp>
Expand Down
2 changes: 0 additions & 2 deletions src/chasers/chaser_check.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@
*/
#include <bitcoin/node/chasers/chaser_check.hpp>

#include <algorithm>
#include <cmath>
#include <memory>
#include <ratio>
#include <bitcoin/node/chasers/chaser.hpp>
#include <bitcoin/node/define.hpp>
Expand Down
1 change: 0 additions & 1 deletion src/chasers/chaser_validate_batch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <bitcoin/node/chasers/chaser_validate.hpp>

#include <atomic>
#include <algorithm>
#include <thread>
#include <bitcoin/node/define.hpp>

Expand Down
1 change: 0 additions & 1 deletion src/estimator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/estimator.hpp>

#include <algorithm>
#include <atomic>
#include <cmath>
#include <ranges>
Expand Down
1 change: 0 additions & 1 deletion src/full_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/full_node.hpp>

#include <utility>
#include <bitcoin/node/chasers/chasers.hpp>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/estimator.hpp>
Expand Down
1 change: 0 additions & 1 deletion src/protocols/protocol_block_in_106.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/protocols/protocol_block_in_106.hpp>

#include <utility>
#include <bitcoin/node/define.hpp>

// The block protocol is partially obsoleted by the headers protocol.
Expand Down
1 change: 0 additions & 1 deletion src/protocols/protocol_block_in_31800.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/protocols/protocol_block_in_31800.hpp>

#include <algorithm>
#include <bitcoin/node/chasers/chasers.hpp>
#include <bitcoin/node/define.hpp>

Expand Down
1 change: 0 additions & 1 deletion src/sessions/session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/sessions/session.hpp>

#include <utility>
#include <bitcoin/node/configuration.hpp>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/full_node.hpp>
Expand Down
1 change: 0 additions & 1 deletion src/settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
#include <bitcoin/node/settings.hpp>

#include <algorithm>
#include <filesystem>
#include <bitcoin/node/define.hpp>
#include <bitcoin/node/estimator.hpp>
Expand Down
Loading