Skip to content

Remove host pool fetch passthrough. #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Sep 2, 2026
Merged

Remove host pool fetch passthrough. #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions include/bitcoin/node/full_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,6 @@ class BCN_API full_node
/// Methods.
/// -----------------------------------------------------------------------

/// Expose the host pool fetch for administrative queries.
void fetch(network::address_handler&& handler) NOEXCEPT override;

/// Get current fee estimate.
void estimate(size_t target, estimator::mode mode,
estimate_handler&& handler) NOEXCEPT;
Expand Down
4 changes: 0 additions & 4 deletions include/bitcoin/node/protocols/protocol.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ class BCN_API protocol
/// Methods.
/// -----------------------------------------------------------------------

/// Fetch a copy of the host pool addresses.
virtual void fetch_addresses(
network::address_handler&& handler) const NOEXCEPT;

/// Maintain a manual connection to the given endpoint.
virtual void connect(const network::config::endpoint& endpoint) NOEXCEPT;

Expand Down
4 changes: 0 additions & 4 deletions include/bitcoin/node/sessions/session.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ class BCN_API session
/// Methods.
/// -----------------------------------------------------------------------

/// Fetch a copy of the host pool addresses.
virtual void fetch_addresses(
network::address_handler&& handler) const NOEXCEPT;

/// Maintain a manual connection to the given endpoint.
virtual void connect(const network::config::endpoint& endpoint) NOEXCEPT;

Expand Down
5 changes: 0 additions & 5 deletions src/full_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,6 @@ time_t full_node::start_time() const NOEXCEPT
// Methods.
// ----------------------------------------------------------------------------

void full_node::fetch(network::address_handler&& handler) NOEXCEPT
{
network::net::fetch(std::move(handler));
}

void full_node::estimate(size_t target, estimator::mode mode,
estimate_handler&& handler) NOEXCEPT
{
Expand Down
6 changes: 0 additions & 6 deletions src/protocols/protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ size_t protocol::address_count() const NOEXCEPT
return session_->address_count();
}

void protocol::fetch_addresses(
network::address_handler&& handler) const NOEXCEPT
{
session_->fetch_addresses(std::move(handler));
}

void protocol::connect(const network::config::endpoint& endpoint) NOEXCEPT
{
session_->connect(endpoint);
Expand Down
6 changes: 0 additions & 6 deletions src/sessions/session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,6 @@ size_t session::address_count() const NOEXCEPT
return node_.address_count();
}

void session::fetch_addresses(
network::address_handler&& handler) const NOEXCEPT
{
node_.fetch(std::move(handler));
}

void session::connect(const network::config::endpoint& endpoint) NOEXCEPT
{
node_.connect(endpoint);
Expand Down
Loading