wfe: Add a CRL handler and record when revocations reach the CRL - #561
Open
Preston12321 wants to merge 1 commit into
Open
Preston12321 wants to merge 1 commit into
Preston12321 wants to merge 1 commit into
Conversation
Add CRLHandler, which serves a freshly signed CRL at the CA's CRL URL, and set CRLVisibleAt on revoked certificates so that revocations appear on the CRL after a random delay. The handler isn't served yet.
Preston12321
added this pull request to stack #559
September 27, 2026 03:47
Preston12321
marked this pull request as ready for review
September 27, 2026 04:06
aarongable
reviewed
Sep 28, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but see my comments on the preceding PR in the stack about getting rid of CRLVisibleAt, and instead caching the most recently-signed CRL for some period of time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CRLHandler, which serves a freshly signed CRL at the CA's CRL URL, and set CRLVisibleAt on revoked certificates so that revocations appear on the CRL after a random delay.
The handler isn't served yet.
Note: This change is entirely generated by Claude, but I provided significant guidance and have manually reviewed the diff