ci: fail release if any expected artifacts are missing#16
Open
kenvandine wants to merge 1 commit into
Open
Conversation
The previous check only verified that at least one artifact existed. This meant a release could be published with missing CUDA builds (as happened with b9549, which was missing all Windows CUDA artifacts and ubuntu-cuda-sm_90-x64). The updated check explicitly enumerates every expected artifact: - All 7 CUDA SM variants (sm_75/80/86/89/90/100/120) for each of: ubuntu x64, ubuntu arm64, windows x64 - ubuntu ROCm, ubuntu OpenVINO, Windows ROCm, Windows CPU If any are absent the step fails before the release is created, so a partially-populated release can never be tagged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fl0rianr
reviewed
Jun 9, 2026
fl0rianr
left a comment
fl0rianr
left a comment
There was a problem hiding this comment.
I don't think this should be the final fix. The artifact manifest check is useful, but this makes releases all-or-nothing: a transient Windows CUDA failure now blocks the entire release.
I'd prefer this as a first step only if we also add a recovery path: publish available artifacts with a clear missing-artifacts list, then allow a manual backfill workflow to rebuild/upload a missing sm_* target for the same tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of lemonade-sdk/lemonade#2163
The previous "Check release artifacts" step only verified that at least one artifact existed. This meant a release could be published with missing CUDA builds — as happened with b9549, which was missing all 7 Windows CUDA artifacts and
ubuntu-cuda-sm_90-x64.Changes
The check now explicitly enumerates every required artifact and fails with actionable error messages before a release is created:
sm_75,sm_80,sm_86,sm_89,sm_90,sm_100,sm_120) for each platform:.tar.xz).tar.xz).7z).tar.gz).tar.gz).zip).zip)If any artifact is absent, the step fails and lists exactly which files are missing — so a partially-populated release can never be tagged.