resolve page-bundle banners with .RelPermalink#203
Conversation
|
🚀 Preview deployment: https://layer5io.github.io/academy-theme/pr-preview/pr-203/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates JSON partials to handle missing banner URLs by outputting null and enhances the resolve-local-resource.html partial to support external, root-relative, and local resource paths. Feedback suggests optimizing the URL resolution logic to support protocol-relative URLs, dynamically match the base path instead of hardcoding /academy/, and simplify redundant string operations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Raunak Madan <madanraunak24@gmail.com>
CodexRaunak
changed the title
1 participant
Notes for Reviewers
Signed commits