feat(blob-v2): configure packed blob file max size with field metadata#7322
Open
jo-migo wants to merge 2 commits into
Open
feat(blob-v2): configure packed blob file max size with field metadata#7322jo-migo wants to merge 2 commits into
jo-migo wants to merge 2 commits into
Conversation
github-actions
Bot
added
A-python
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Fixes: lance-format#7292 Problem: There's currently no way to encode a threshold for maximum packed blob sidecar file size into a dataset in the way that you can encode inline blob and dedicated blob size thresholds via `lance-encoding:blob-dedicated-size-threshold` and `lance-encoding:blob-inline-size-threshold` respectively. Solution: Add a new `lance-encoding:blob-pack-file-size-threshold` field-level metadata key which informs the blob writer to only start new packed files when current packed file reaches that threshold. It can be overridden by supplying another value via the existing `blob_pack_file_size_threshold` parameter to the `write_dataset` function.
jo-migo
force-pushed
the
fix-packed-storage-filesize
branch
from
e6b4c40 to
08c0e06
Compare
jo-migo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#7292
Problem
There's currently no way to encode a threshold for maximum packed blob sidecar file size into a dataset in the way that you can encode inline blob and dedicated blob size thresholds via
lance-encoding:blob-dedicated-size-thresholdandlance-encoding:blob-inline-size-thresholdrespectively.Solution
Add a new
lance-encoding:blob-pack-file-size-thresholdfield-level metadata key which informs the blob writer to only start new packed files when current packed file reaches that threshold.It can be overridden by supplying another value via the existing
blob_pack_file_size_thresholdparameter to thewrite_datasetfunction.