Repository navigation
fix(cli): preserve cluster command arguments - #352
Merged
Merged
Conversation
Multi-server invocations use the positional destination field as the initial remote command, so applying SSH hostname parsing rejected shell syntax before configuration and node resolution. Treat destination parsing as SSH-mode-only while keeping explicit user and port overrides available to multi-server connections. Add unit and isolated process regression coverage for implicit and explicit command invocation while retaining invalid SSH hostname checks. Refs #351
inureyes
added
type:bug
inureyes
added a commit
that referenced
this pull request
Nov 5, 2026
Bump the crate, lockfile, and manpages to 3.1.1 and add release entries to README, CHANGELOG, and debian/changelog covering #349, #350, #352, and #353: the cluster command argument fix, the russh 0.65.1 upgrade with staged host-key verification, session-bind on agent connections, and the dependency refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cluster and
--hostscommands containing spaces or shell syntax were parsed as SSH destinations and failed hostname validation. Restrict destination parsing to SSH mode while retaining explicit user/port options and strict validation of actual destinations. Add unit and offline subprocess regression coverage.Validation
cargo fmt --checkandcargo clippy -- -D warningspass.cargo test --lib: 1,968 passed; 0 failed.cargo test --tests -- --skip integration_test: 2,643 passed; 0 failed; 8 ignored across 54 suites.Closes #351