Skip to content

[cinder-csi-plugin] Configure topology with --with-topology - #3155

Open
234u34k wants to merge 1 commit into
kubernetes:masterfrom
234u34k:codex/cinder-csi-topology-flag
Open

[cinder-csi-plugin] Configure topology with --with-topology#3155
234u34k wants to merge 1 commit into
kubernetes:masterfrom
234u34k:codex/cinder-csi-topology-flag

Conversation

@234u34k

@234u34k 234u34k commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The Cinder chart currently applies csi.provisioner.topology only to the external-provisioner feature gate, so the value does not control the Cinder driver topology capabilities.

This uses the existing value for --with-topology in both Cinder driver containers and removes the explicit external-provisioner feature-gate argument. The existing "true" default is unchanged. The pinned external-provisioner v5.3.0 enables its GA Topology gate by default, while "false" now makes the driver stop advertising and returning topology information.

The affected documentation is updated and an explicit disabled-values render is added to chart CI. This follows #2998, which established the required driver behavior.

Which issue this PR fixes(if applicable):

Fixes #2993

Special notes for reviewers:

Validated with Helm v3.10.0:

  • helm lint passes with defaults and every ci/*-values.yaml file.
  • The default render passes --with-topology=true to both driver containers.
  • The disabled render passes --with-topology=false to both driver containers.
  • Neither render sets the external-provisioner Topology feature gate.
  • Existing driver extraArgs retain their override precedence.
  • git diff --check origin/master...HEAD passes.

Release note:

[cinder-csi-plugin] Fixed the Helm chart so `csi.provisioner.topology: "false"` disables topology awareness in both the controller and node plugins.

@kubernetes-prow kubernetes-prow Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 31, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from gouthampacha and zetaab July 31, 2026 22:32
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @234u34k. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2026
@gouthampacha

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2026

@gouthampacha gouthampacha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @234u34k.

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2026
@234u34k

234u34k commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

/assign @stephenfin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cinder-csi-plugin: use of .Values.csi.provisioner.topology and --with-topology

3 participants