[cinder-csi-plugin] Configure topology with --with-topology - #3155
[cinder-csi-plugin] Configure topology with --with-topology#3155234u34k wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @234u34k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
gouthampacha
left a comment
There was a problem hiding this comment.
/lgtm
thanks @234u34k.
|
/assign @stephenfin |
What this PR does / why we need it:
The Cinder chart currently applies
csi.provisioner.topologyonly to the external-provisioner feature gate, so the value does not control the Cinder driver topology capabilities.This uses the existing value for
--with-topologyin both Cinder driver containers and removes the explicit external-provisioner feature-gate argument. The existing"true"default is unchanged. The pinned external-provisioner v5.3.0 enables its GA Topology gate by default, while"false"now makes the driver stop advertising and returning topology information.The affected documentation is updated and an explicit disabled-values render is added to chart CI. This follows #2998, which established the required driver behavior.
Which issue this PR fixes(if applicable):
Fixes #2993
Special notes for reviewers:
Validated with Helm v3.10.0:
helm lintpasses with defaults and everyci/*-values.yamlfile.--with-topology=trueto both driver containers.--with-topology=falseto both driver containers.Topologyfeature gate.extraArgsretain their override precedence.git diff --check origin/master...HEADpasses.Release note: