Skip to content

change(web): remove TokenizationCorrector class only used in epic/boundary-correction - #16581

Merged
jahorton merged 1 commit into
masterfrom
change/web/remove-tokenization-corrector
Sep 18, 2026
Merged

jahorton merged 1 commit into
masterfrom
change/web/remove-tokenization-corrector

Conversation

@jahorton

Copy link
Copy Markdown
Contributor

This class, intended for use in epic/boundary-correction, had an early version 'land' in epic/autocorrect. It's only used in unit tests, though, and is not integrated into the predictive-text engine. Furthermore, some changes we may want for this release cycle will require we either remove this set of classes or patch them up... so let's just drop them for 19.0 beta and restore them on epic/boundary-correction.

Build-bot: skip build:web
Test-bot: skip

…ndary-correction

Build-bot: skip build:web
Test-bot: skip
@keymanapp-test-bot

keymanapp-test-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web (no artifacts on BuildLevel "build")
    • KeymanWeb Test Home - build : ✅ all tests passed

@keymanapp-test-bot keymanapp-test-bot Bot added this to the B19S2 milestone Sep 16, 2026
@github-actions github-actions Bot added web/ web/predictive-text/ change Minor change in functionality, but not new labels Sep 16, 2026
@mcdurdin

Copy link
Copy Markdown
Member

How did keymanweb.js end up 1641 bytes larger than before? Or is the check confused?

@jahorton

Copy link
Copy Markdown
Contributor Author

How did keymanweb.js end up 1641 bytes larger than before? Or is the check confused?

I'm going to guess it's #16450, which was probably merged since the last alpha build.

@jahorton
jahorton merged commit 00a9b66 into master Sep 18, 2026
8 of 9 checks passed
@jahorton
jahorton deleted the change/web/remove-tokenization-corrector branch September 18, 2026 13:08
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Sep 18, 2026
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.288-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change Minor change in functionality, but not new web/predictive-text/ web/

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants