chore(android): upload webview source map during android and ios build - #16449
chore(android): upload webview source map during android and ios build#16449ermshiperete wants to merge 3 commits into
Conversation
Previously we uploaded the webview source map during a web build. This can lead to problems because that is not the actual artifact used for Android and iOS. This change therefore moves uploading the webview source map to Sentry to the android and ios builds. Build-bot: skip build:web,android,ios Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
github-actions
Bot
added
web/
android/
ios/
android/engine/
ios/engine/
resources/
chore
labels
| } | ||
|
|
||
| builder_run_action test:help do_test_help | ||
| builder_run_child_actions publish-symbols |
There was a problem hiding this comment.
I don't think publish-symbols is ever called for iOS, would need to be added to resources/teamcity/ios?
There was a problem hiding this comment.
Good catch! Done
|
Suggest changing the build bot so we can verify the symbol upload: |
Build-bot: skip release:web,android,ios
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM, just polish nits. Thanks for working on this!
| fi | ||
| } | ||
|
|
||
| function sentry_upload_web () { |
There was a problem hiding this comment.
Can you add a comment on parameters and tweak to use a local VAR=$1 pattern at the top of the function like we do elsewhere in shared scripts?
| return | ||
| fi | ||
|
|
||
| echo "Uploading $1 to Sentry..." |
There was a problem hiding this comment.
We should use builder_echo throughout
|
|
||
| function sentry_upload_web () { | ||
| if ! isSentryConfigured; then | ||
| echo "Skipping Sentry upload: SENTRY_ORG and/or SENTRY_PROJECT are unset." |
There was a problem hiding this comment.
| echo "Skipping Sentry upload: SENTRY_ORG and/or SENTRY_PROJECT are unset." | |
| builder_warn "Skipping Sentry upload: SENTRY_ORG and/or SENTRY_PROJECT are unset." |
| # --strip-common-prefix does not take an argument, unlike --strip-prefix. It auto-detects | ||
| # the most common prefix instead. |
There was a problem hiding this comment.
This is not a terribly useful comment (I know you didn't write it).
There was a problem hiding this comment.
Removed comment
There was a problem hiding this comment.
Is there a reason we do a direct call here but use builder_launch in the new code?
There was a problem hiding this comment.
I guess not. The new code was copied from Android.
I now changed the calls here to use builder_launch as well.
Co-authored-by: Marc Durdin <marc@durdin.net>
3 participants
Previously we uploaded the webview source map during a web build. This can lead to problems because that is not the actual artifact used for Android and iOS.
This change therefore moves uploading the webview source map to Sentry to the android and ios builds.
Build-bot: skip release:web,android,ios
Test-bot: skip