Skip to content

fix/hardware revision selector optional#1941

Open
alanpeixinho wants to merge 2 commits into
kernelci:mainfrom
profusion:fix/hardware-revision-selector-optional
Open

fix/hardware revision selector optional#1941
alanpeixinho wants to merge 2 commits into
kernelci:mainfrom
profusion:fix/hardware-revision-selector-optional

Conversation

@alanpeixinho

@alanpeixinho alanpeixinho commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What it is

  • Make the revision selectors in hardware listing page optional

How to test it

  • Go to the hardware listing page
  • The hardware listing should load the full hardware listing.
  • When selecting a revision, the hardware listing should be filtered to count only instances of that revision.
  • When deselecting the filter the page behaviour should go back to full listing.
  • Simplify query to use revisions built on last 30 days, instead of tests ran on last 15 days.

Closes #1939

@alanpeixinho alanpeixinho force-pushed the fix/hardware-revision-selector-optional branch from 6c13bf0 to d07281a Compare June 15, 2026 20:44
@alanpeixinho alanpeixinho marked this pull request as draft June 15, 2026 21:23
@alanpeixinho alanpeixinho force-pushed the fix/hardware-revision-selector-optional branch from d07281a to 5694381 Compare June 17, 2026 16:43
@alanpeixinho alanpeixinho marked this pull request as ready for review June 17, 2026 16:45
@alanpeixinho alanpeixinho force-pushed the fix/hardware-revision-selector-optional branch from 5694381 to 6a67009 Compare June 17, 2026 16:50
@alanpeixinho alanpeixinho force-pushed the fix/hardware-revision-selector-optional branch from 6a67009 to fc47f95 Compare June 19, 2026 18:02
@mentonin

Copy link
Copy Markdown
Contributor

I would split the commit into backend changes, frontend changes, and internationalization, if possible

Query builds directly instead of joining tests, look back 30 days,
and drop custom cache timeout on selectors endpoint.

Part of kernelci#1939

Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
@alanpeixinho alanpeixinho force-pushed the fix/hardware-revision-selector-optional branch from fc47f95 to c0b9b0e Compare June 19, 2026 18:38
Keep both revision-scoped and default hardware listing endpoints,
add clearable tree/branch/revision selectors, and include e2e tests.

Closes kernelci#1939

Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
@alanpeixinho alanpeixinho force-pushed the fix/hardware-revision-selector-optional branch from c0b9b0e to d36f490 Compare June 19, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use hardware page revisions listing as a filter

2 participants