Add orc-crds and orc helm charts - #926
Merged
Merged
Conversation
Add hack/gen-helm.sh which copies the manager ClusterRole from config/rbac/role.yaml into charts/orc/templates/rbac/ with the name templated for Helm. CRDs are handled by a symlink (charts/orc-crds/crds -> config/crd/bases/) and need no generation step. Wire the script into 'make generate' via a new generate-helm target so chart content stays in sync automatically and is validated by the existing verify-generated CI check.
Provides the ORC CRDs as a standalone Helm chart. The crds/ directory is a symlink to config/crd/bases/ so the chart always reflects the current generated CRDs with zero duplication. Uses Helm's native crds/ directory so CRDs are installed before other resources and are not removed on helm uninstall. Co-authored-by: Lola Delannoy <ldelannoy@wiremind.io>
Deploys the ORC controller manager with configurable image, resources, replicas, probes, metrics, and RBAC. The manager ClusterRole (templates/rbac/manager-clusterrole.yaml) is generated by hack/gen-helm.sh from config/rbac/role.yaml so it stays in sync as controllers are added. All other RBAC and templates are hand-authored and rarely change. Co-authored-by: Lola Delannoy <ldelannoy@wiremind.io>
Add a 'helm' job to the existing release workflow that packages both charts and pushes them as OCI artifacts to oci://quay.io/orc/helm/ on v* tags. Rename the workflow from 'release image' to 'release' since it now covers images and charts. Also add *.tgz to .gitignore for local helm package output.
winiciusallan
approved these changes
Sep 28, 2026
winiciusallan
left a comment
Member
There was a problem hiding this comment.
Long time ago I started sketching a helm chart for ORC, and it follows the same basic structure, but way more complete. Feel free to merge whenever you think this is ready.
Collaborator
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #348.
Fixes #331