Repository navigation
Conversation
When the global config sets user.name or user.email more than once, git refuses to overwrite the values with a single one (exit code 5), so the identity dialog couldn't save. Write them through flowSetGitConfig, which passes --all (--replace-all for git <= 2.45), and give it a config level for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the global config sets user.name or user.email more than once (e.g. after
git config --add), the identity dialog can't save: git won't overwrite several values with one and exits with code 5.SetUpGitIdentity now writes through flowSetGitConfig, which passes
--all(--replace-allfor git <= 2.45); flowSetGitConfig gets alevelargument for--global.Tested: the new test fails on master; full suite on PyQt6, PySide6 and PyQt5 (testToggleWordWrap fails on master too, #208); commit and remote tests on Windows 11; the old-git commands with git 2.34.
Prepared with Claude Code; I reviewed the changes.
Checklist