Skip to content

SetUpGitIdentity: Replace every global user.name/email value - #214

Open
Grinv wants to merge 1 commit into
jorio:masterfrom
Grinv:identity-config-all
Open

Grinv wants to merge 1 commit into
jorio:masterfrom
Grinv:identity-config-all

Conversation

@Grinv

@Grinv Grinv commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

If the global config sets user.name or user.email more than once (e.g. after git config --add), the identity dialog can't save: git won't overwrite several values with one and exits with code 5.

SetUpGitIdentity now writes through flowSetGitConfig, which passes --all (--replace-all for git <= 2.45); flowSetGitConfig gets a level argument for --global.

Tested: the new test fails on master; full suite on PyQt6, PySide6 and PyQt5 (testToggleWordWrap fails on master too, #208); commit and remote tests on Windows 11; the old-git commands with git 2.34.

Prepared with Claude Code; I reviewed the changes.

Checklist

When the global config sets user.name or user.email more than once,
git refuses to overwrite the values with a single one (exit code 5),
so the identity dialog couldn't save.

Write them through flowSetGitConfig, which passes --all
(--replace-all for git <= 2.45), and give it a config level for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant