Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains([true], 1)currently returnstrue, although the scalar expressiontrue == 1returnsfalse. The same problem occurs forfalseand zero because array membership uses Python equality.Use the existing JMESPath comparator for array elements so membership agrees with scalar comparisons. String containment keeps its existing behavior. The comparator is imported at call time because the visitor already imports the functions module.
Tests cover both argument directions, float equivalents, matching booleans, numeric equality, null, strings, empty arrays, and a later matching element. All six boolean/number regressions fail on the original code. On Windows with Python 3.12.2,
python -m pytest tests -qpasses with 993 passed, 1 skipped, and 12 passing subtests; wheel and sdist builds also pass.This leaves the separate nested-container equality issue in #372 and string argument handling in #360 to those changes.