CP-21164: run e2e-tests since they don't run on PRs from forks - #826
Merged
FelixPhipps merged 1 commit intoAug 28, 2026
Merged
Conversation
…tion tests CI sets both from real secrets at the job level (for the separate ARK_LIVE_TEST-gated live test), so three subtests asserting on an empty username/secret picked up real ambient values instead of the empty baseline they assumed locally.
mladen-rusev-cyberark
added
test-e2e
Member
|
Seems logical. Approved! |
FelixPhipps
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #825
Re-raises #825 from a branch in this repository rather than a fork, and carries the same
one commit (cherry-picked, original author preserved).
Why re-raise it here
The label-gated e2e jobs in
.github/workflows/tests.yaml—ark-test-e2e(test-ark),ngts-test-e2e(test-ngts) andtest-e2e(test-e2e) — all depend on repositorysecrets (
GCP_SA_KEY,ARK_SUBDOMAIN/ARK_USERNAME/ARK_SECRET,ARK_OCI_BASE,NGTS_PRIVATE_KEY). GitHub does not expose secrets topull_requestruns from forks, sothose jobs cannot pass — or even meaningfully run — on #825. Granting write access to the
fork's author wasn't an option, so the branch lives here instead.
With the three labels applied, all e2e jobs run on this PR.
What the change fixes
TestConfig_CyberArk_Validationwas added alongside the Conjur JWT work and asserts onbehaviour that only holds when
ARK_USERNAME/ARK_SECRETare unset. Thetestjob intests.yamlsets both from real secrets at the job level (they exist for the separateARK_LIVE_TEST-gated live test), so those subtests inherit real credentials and fail onmaster:neither service_id nor ARK_USERNAME is an error at config timeARK_USERNAME without ARK_SECRET is an error at config timecluster_name is empty when cluster_name, cluster_id, and ARK_USERNAME are all unsetThe fix clears both variables in the shared
setEnvhelper so the subtests are hermetic.Subtests that need non-empty values set them after calling
setEnv, so nothing isclobbered. This is a test-isolation fix only — no production code changes.