Repository navigation
Conversation
npm 12 blocks install scripts of dependencies unless they are listed in `allowScripts` of package.json. js-controller's install script runs `setup first`, so the test installation stayed empty and the integration tests failed with `iobroker-data/iobroker.json: ENOENT`. esbuild (via @alcalzone/esbuild-register) downloads its binary in its install script. Both are now listed in `allowScripts` of the generated package.json. Older npm versions ignore the field. Also updates package-lock.json after `npm install` with npm 12. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VbBXwNK1HEqo3JfpuhT6k9
Contributor
|
a) See issue ioBroker/ioBroker.js-controller#3544. Maybe js-controller can be removed here. b) Why is js-controller not named iobroker.jscontroller but uses a contruct based on a variable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm 12 blocks install scripts of dependencies unless they are listed in
allowScriptsof package.json. js-controller's install script runssetup first, so the test installation stayed empty and the integration tests failed withiobroker-data/iobroker.json: ENOENT. esbuild (via @alcalzone/esbuild-register) downloads its binary in its install script.Both are now listed in
allowScriptsof the generated package.json. Older npm versions ignore the field.Also updates package-lock.json after
npm installwith npm 12.