fix(db): repair model_relationships foreign keys broken by migration 22#9272
Merged
lstein merged 5 commits intoJun 24, 2026
Merged
Conversation
Migration 22 rebuilds the `models` table by renaming it to `models_old`, creating a fresh `models` table, and dropping `models_old`. Modern SQLite (legacy_alter_table off) rewrites foreign-key references in other tables on rename, so the FKs in `model_relationships` were repointed at `models_old`, which was then dropped. This broke ON DELETE CASCADE and integrity for related models. Add migration 32 to rebuild `model_relationships` with its foreign keys referencing `models(id)` again, preserving existing links and dropping any orphaned rows. Idempotent and a no-op when the FKs are already correct.
Pfannkuchensack
requested review from
JPPhoto,
blessedcoolant,
dunkeroni and
lstein
as code owners
github-actions
Bot
added
python
Pfannkuchensack
added a commit
that referenced
this pull request
Jun 12, 2026
…nst drift - Declare the models/workflow_library GENERATED columns as SQLAlchemy Computed so create_all() reproduces them on MySQL/Postgres (json_unquote(json_extract(...))); no migration, no models-table rebuild (avoids re-breaking the #9272 FK fix). - Add a schema-parity guard test that diffs the migration-built SQLite schema against SQLModel.metadata and compiles DDL for sqlite/mysql/postgres — fails on any future migration that models.py doesn't track. - Close post-merge drift: image_subfolder (was crashing image save), delete_intermediates pairs, status_sequence, user_sessions/user_invitations tables. - Use TEXT/LONGTEXT for JSON blobs; onupdate=utcnow on all updated_at columns; set session_queue status_sequence/started_at/completed_at app-side (no triggers on MySQL).
dunkeroni
pushed a commit
to dunkeroni/InvokeAI
that referenced
this pull request
Jun 29, 2026
…22 (invoke-ai#9272) * fix(db): repair model_relationships foreign keys broken by migration 22 Migration 22 rebuilds the `models` table by renaming it to `models_old`, creating a fresh `models` table, and dropping `models_old`. Modern SQLite (legacy_alter_table off) rewrites foreign-key references in other tables on rename, so the FKs in `model_relationships` were repointed at `models_old`, which was then dropped. This broke ON DELETE CASCADE and integrity for related models. Add migration 32 to rebuild `model_relationships` with its foreign keys referencing `models(id)` again, preserving existing links and dropping any orphaned rows. Idempotent and a no-op when the FKs are already correct. * Chore Ruff Format --------- Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration 22 rebuilds the
modelstable by renaming it tomodels_old, creating a freshmodelstable, and droppingmodels_old. Modern SQLite (legacy_alter_table off) rewrites foreign-key references in other tables on rename, so the FKs inmodel_relationshipswere repointed atmodels_old, which was then dropped. This broke ON DELETE CASCADE and integrity for related models.Add migration 32 to rebuild
model_relationshipswith its foreign keys referencingmodels(id)again, preserving existing links and dropping any orphaned rows. Idempotent and a no-op when the FKs are already correct.Related Issues / Discussions
fix for #8625
QA Instructions
model_relationshipsforeign keys will reference the droppedmodels_oldtable — verify with:pytest tests/app/services/shared/sqlite_migrator/migrations/test_migration_32.py(8 tests, covering FK repair, link preservation, orphan drop, cascade, index recreation, idempotency, and the no-table no-op case).Merge Plan
This touches the DB schema and adds a new migration. Migration number
32is currently free onmain, but other in-flight branches also use32/33— coordinate the merge order and renumber if one of those lands first. No special release timing required beyond that; the migration auto-backs up the DB and is a no-op on databases whose foreign keys are already correct.Checklist
What's Newcopy (if doing a release after this PR)