[benchmarker] Add SCD subscription actions - #1666
Open
BenjaminPelletier wants to merge 4 commits into
Open
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 26, 2026 00:08
mickmis
approved these changes
Aug 26, 2026
| [if uss == 1 then "setup"]: ['Create subscription %d' % sub_index for sub_index in std.range(1, num_subscriptions)], | ||
| load: 'Flight planner ramp for USS %d' % uss, | ||
| [if uss < num_uss || dss_config < std.length(dss_config_names) then "teardown"]: ['Generate intermediate artifacts'], | ||
| [if uss < num_uss || dss_config < std.length(dss_config_names) || uss == num_uss then "teardown"]: |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| [if uss < num_uss || dss_config < std.length(dss_config_names) || uss == num_uss then "teardown"]: | |
| [if uss <= num_uss || dss_config < std.length(dss_config_names) then "teardown"]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors the subscription management actions implemented for F3411 in F3548. Currently, each individual virtual user potentially manages subscriptions intended to cover many virtual users, and this can lead to difficulties. Plus, the virtual-user-centric subscription logic is probably not correct currently when the subscription already exists from a previous, different test. I'm expecting moving "permanent" subscription management to actions for F3548 will help address both challenges.
My intent following this PR is to remove subscription management from the F3548 virtual user workflow to reduce the complexity of benchmarker logic.
A single_s2_cell.jsonnet run with action-based subscription management was successful in executing the actions and produced: