Fix ServerSpec | undefined type safety and wire up TS project references - #414
Open
isc-klu wants to merge 10 commits into
Open
Fix ServerSpec | undefined type safety and wire up TS project references#414isc-klu wants to merge 10 commits into
ServerSpec | undefined type safety and wire up TS project references#414isc-klu wants to merge 10 commits into
Conversation
- Fix getServerSpec and ProtocolMethods resolveFromUri to return ServerSpec | undefined - Add guards at all getServerSpec call sites across providers - Fix resolveServerSpec in client to avoid non-null assertion - Add TS project references for common from client/server/root - Update clean script to remove tsbuildinfo files - Rename deprecated typescript.* settings to js/ts.*
isc-klu
marked this pull request as ready for review
August 21, 2026 16:28
| // Make the request | ||
| const respdata = await makeRESTRequest("POST", 1, "/action/query", { ...server, namespace }, querydata); | ||
| const respdata = | ||
| server && (await makeRESTRequest("POST", 1, "/action/query", { ...server, namespace }, querydata)); |
Collaborator
There was a problem hiding this comment.
You can avoid all these diffs by putting the server check inside makeRESTRequest(). Dispatching to that method is free; we just don't want to send the request to the client needlessly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #413.
Summary
getServerSpec()could returnundefinedat runtime, but was typed as always returningServerSpec, silently masking unresolved-server crashes at every call site. This PR fixes the types, adds guards, and wires up TS project references socommon's types are enforced acrossclient/server.Changes
common/src/types.ts:ProtocolMethods["intersystems/server/resolveFromUri"]now returnsPromise<ServerSpec | undefined>.server/src/utils/functions.ts:getServerSpecreturn type fixed toPromise<ServerSpec | undefined>.server/src/utils/types.ts/variables.ts: ExportedProtocolMethods;connection.sendRequestnow strongly typed against it.completion.ts,definition.ts,diagnostic.ts,documentLink.ts,formatting.ts,hover.ts,refactoring.ts,signatureHelp.ts,typeDefinition.ts,typeHierarchy.ts): Addedif (!server) { ... }guards at eachgetServerSpeccall site with appropriate fallback returns (or a thrown error inonDiagnostics).client/src/extension.ts:resolveServerSpecreturnsPromise<ServerSpec | undefined>instead of using a non-null assertion; caller usesserverSpec?.active.commonis now a composite project referenced byclient,server, and the roottsconfig.json. AddedskipLibCheck: truetoclient/server.package.json:cleanscript now also removestsconfig.tsbuildinfofiles..vscode/settings.json: Renamed deprecatedtypescript.*settings tojs/ts.*equivalents; unrelatedobjectscript.conn.active: falsepicked up locally (droppable if preferred).Testing
npm run compile(tsc -b) completes with zero errors.