Add opt-in Synology Hyper Backup WebDAV mode#608
Open
taglia wants to merge 1 commit into
Open
Conversation
79ea69f to
3011c72
Compare
3011c72 to
a86375f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an opt-in WebDAV compatibility/performance mode for Synology Hyper Backup, enabled with
WEBDAV_HYPER_BACKUP_MODE=true.The default WebDAV behavior remains unchanged unless this flag is enabled.
Motivation
Synology Hyper Backup performs many repeated WebDAV metadata and listing operations while creating tasks, uploading backup chunks, and restoring data. Against the current WebDAV implementation this can result in long idle periods between uploads and very slow overall backup throughput.
In the tested environment, this reduced the estimated time to upload 100 GB with Hyper Backup from about 72 hours to about 11.5 hours.
Changes
WEBDAV_HYPER_BACKUP_MODEconfiguration support.GET, andHEADlookups.Validation
Tested with Synology Hyper Backup using the Docker WebDAV container.
Performance observed in the same environment:
WEBDAV_HYPER_BACKUP_MODE=trueAdditional validation:
main, completed a 4.1 GB backup/restore smoke test.Notes
This is intentionally gated behind
WEBDAV_HYPER_BACKUP_MODE=truebecause some behavior is tailored to Synology Hyper Backup's WebDAV access pattern, especially zero-byte placeholder handling and stale lock keepalive cleanup.