Feature/signal value format registry - #697
Open
desmonddak wants to merge 4 commits into
Open
Conversation
mkorbel1
reviewed
Aug 18, 2026
| import 'package:rohd_devtools_widgets/rohd_devtools_widgets.dart'; | ||
|
|
||
| void main() { | ||
| test('formats bare binary and hexadecimal waveform values', () { |
Contributor
There was a problem hiding this comment.
some of these are surprising to me. How does it know 11111111 is binary and not decimal or hex? how does it know ff is hex?
| import 'package:rohd_devtools_widgets/rohd_devtools_widgets.dart'; | ||
|
|
||
| void main() { | ||
| test('formats bare binary and hexadecimal waveform values', () { |
Contributor
There was a problem hiding this comment.
some of these are surprising to me. How does it know 11111111 is binary and not decimal or hex? how does it know ff is hex?
| SignalValueFormatRegistry._(); | ||
|
|
||
| /// Current occurrence-format preferences. | ||
| static final formats = ValueNotifier<Map<String, String>>( |
Contributor
There was a problem hiding this comment.
why aren't we using enums for the different supported types?
| ); | ||
| }); | ||
|
|
||
| test('looks up a uniquely matching hierarchy suffix', () { |
Contributor
There was a problem hiding this comment.
i'm confused why these non-matching things should match? it always matches any suffix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This is a dependency needed as central for widgets to communicate changes in the way a signal value is displayed.
Related Issue(s)
None.
Testing
This feature is used in future widgets where testing is performed, but not introduced yet. But basic testing for store/recall of format is performed.
Backwards-compatibility
No.
Documentation
No, not yet. This is a narrow dependency needed to introduce future widgets.