[inteltdelisle]

Four places in CodeGen checked whether a variable is a work-group local by looking for SYCLScopeAttr on the variable or on its type, with slight differences between them. Replace them with CGSYCLRuntime::getWorkGroupVarKind, which distinguishes hierarchical parallelism locals (attribute on the variable) from wg_scope types such as work_group_static (attribute on the type).

Generated code is unchanged.

Add CodeGen tests for wg_scope types, and extend the hierarchical parallelism tests to cover private_memory, wg_scope types and const locals.

Fixes #23626

Co-Authored-By: Claude Opus 5.5

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

• These checks hardcode Itanium-mangled internal symbol names, which makes the test more brittle to… · New
• CHECK-NOT: __cxa_guard is currently module-wide and can become a false-failure if unrelated code… · New
• The last clause is ambiguous given the new distinction between HoistedAutomatic (attr on the… · New

What changed in this PR

Unifies SYCL work-group scope variable detection in CodeGen by routing all checks through a single helper that distinguishes hierarchical hoisted locals from wg_scope types, and adds/extends CodeGenSYCL tests to cover these cases.

Changes:

• Introduce CGSYCLRuntime::getWorkGroupVarKind() and use it in multiple CodeGen locations to consistently classify work-group variables.
• Adjust initialization handling so only hierarchical hoisted locals get the special “no guarded init + store-based init” path.
• Add/extend CodeGenSYCL tests for wg_scope-decorated types, private_memory, and const locals in hierarchical kernels.

File	Description
clang/​test/​CodeGenSYCL/​wg_scope_class.cpp	New test validating wg_scope-type variables are emitted in local AS and are zero-initialized like statics.
clang/​test/​CodeGenSYCL/​wg_init.cpp	Extends hierarchical WG init test to cover private_memory and wg_scope types.
clang/​test/​CodeGenSYCL/​const-wg-init.cpp	Extends const hierarchical WG local test with an explicit global undef check.
clang/​lib/​CodeGen/​CodeGenModule.cpp	Use unified work-group variable classification to choose local address space for globals.
clang/​lib/​CodeGen/​CGSYCLRuntime.h	Adds WorkGroupVarKind enum and getWorkGroupVarKind() API.
clang/​lib/​CodeGen/​CGSYCLRuntime.cpp	Implements getWorkGroupVarKind() and uses it to validate WG local emission.
clang/​lib/​CodeGen/​CGDecl.cpp	Replace ad-hoc attribute checks with unified kind query and refine WG init handling.

_{Review effort: Lite}