Repository navigation
[SYCL] Testing follow-up to #23437. - #23641
Open
inteltdelisle wants to merge 1 commit into
Open
inteltdelisle wants to merge 1 commit into
inteltdelisle wants to merge 1 commit into
Conversation
`sycl::span` was updated in intel#23437 to match C++20 `std::span` but did not add much test coverage for the new behaviour. This extends `sycl/test/basic_tests/span.cpp` to cover: - Constructors and copy assignment - Deduction guides for every constructor kind - Observers: size(), size_bytes() and empty() - Element access: operator[], front(), back() and data() - Iterators: forward, reverse, range-for, and empty spans - first, last and subspan - as_bytes and as_writable_bytes - Type traits - Invalid constructions and conversions - Precondition failures that make constant evaluation fail Signed-off-by: Delisle, Thierry <thierry.delisle@intel.com>
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sycl::spanwas updated in #23437 to match C++20std::spanbut did not add much test coverage for the new behaviour. This extendssycl/test/basic_tests/span.cppto cover: