feat(ui-text-input,ui-select): add forcePlaceholder prop to TextInput#2643
Open
HerrTopi wants to merge 1 commit into
Open
feat(ui-text-input,ui-select): add forcePlaceholder prop to TextInput#2643HerrTopi wants to merge 1 commit into
HerrTopi wants to merge 1 commit into
Conversation
Add an optional forcePlaceholder prop (default false) to TextInput v2 that always renders the placeholder when the input is empty, regardless of the interaction type. Previously the placeholder only showed when interaction was 'enabled'. Wire the prop into Select v2's trigger TextInput so a Select can display its placeholder even when it is not in the enabled interaction state. Ref: INSTUI-5104 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression report✅ No changes.
Baselines come from the |
matyasf
reviewed
Jul 20, 2026
| nextProps.selectOption.props.renderBeforeLabel && | ||
| nextProps.selectOption.props.renderBeforeLabel && | ||
| prevProps.selectOption.props.renderAfterLabel === | ||
| nextProps.selectOption.props.renderAfterLabel && |
Collaborator
There was a problem hiding this comment.
The formatting was broken in this commit: cda547a#diff-86c34ad67bd876370225bf0df1e248d809d3ac768f41267d08d576d0ef2d0ec1
This is just a revert (and makes the whole thing a pain to read!)
matyasf
approved these changes
Jul 20, 2026
ToMESSKa
requested changes
Jul 22, 2026
Contributor
There was a problem hiding this comment.
The forced placeholder text currently has no styling (any styling depends on it being interaction === 'enabled' in TextInput/v2/styles.ts). I think it has too low of a contrast in the dark theme, around 2.1:1.
I also see a comment in TextInput/v2/styles.ts which says "placeholder is not rendered in the readOnly and disabled state", which should be removed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forcePlaceholderprop (defaultfalse) to TextInput v2 that renders the placeholder when empty regardless of interaction typeforcePlaceholderto Select v2's trigger TextInput so a Select shows its placeholder outside the enabled interaction stateTest Plan
readonly/disabledinteraction withforcePlaceholderand confirm the placeholder text shows while empty, and disappears once a value is enteredFixes INSTUI-5104
🤖 Generated with Claude Code